I was fixing some code written by an intrepid junior the other day and came upon this beauty:
var day = 1000*60*60*24; var week = day*7; var yesterday = new Date(today.getTime() - day); var lastWeek = new Date(today.getTime() - week);
Looks pretty good, right? It calculates the timestamp for yesterday and a timestamp for last week by deducting the amount of milliseconds in a day and a week from the current time. Clever.
But wait … Does it smell bad to you? I’ll give you a minute.
How about now? Are your nose hairs sizzling yet?
Maybe not. I mean, we’ve all written code like this. Maybe not recently, but for sure when we were starting out. Even the internet didn’t smell anything.
Pop quiz: Why is this code wrong? var day = 1000*60*60*24
— Swizec (@Swizec) November 3, 2015
There’s less context, but the smelliest line of code is still there.
Answers ranged from the slightly missing the point:
@Swizecbecause there aren't 60,000 seconds in a minute. context would be helpful
— Aron (@MrAronD) November 3, 2015
To the snarky:
@swizec You should use ES6's const instead of var…
— Anže Pečar (@Smotko) November 3, 2015
And even some that tried to do a linter’s job.
They all have a point, but none of them got the point.
60*60*24 seconds long. They are
1 day long, which on most days maps to
60*60*24 = 86400 seconds. But not on all days.
Thanks to the wonder that is daylight savings time (DST), we have a day that’s only 23 hours long. We also have a day that’s 25 hours long. Then, every few years, we have a day that’s 86,401 seconds long. In theory, we could even have a day that’s 86,399 seconds long. It’s unlikely, but it’s possible.
But, I mean, who cares, right? It’s just an hour here, an hour there, and maybe a second when no one’s paying attention. Nobody’s going to notice. 24 hours ago should still mean yesterday.
Here’s the thing, though. Just because it’s yesterday doesn’t mean it’s also 1 day ago.
Let’s say this code runs between 2 am and 3 am on the days when daylight savings time goes away. First of all, not all countries do the change; not even all US states do. Second of all, there are two instances of the hour between 2 am and 3 am.
Let me show you some examples:
new Date((new Date("<a href="tel:2015110102">2015-11-01 02</a>:59 pst").getTime()-1000*60*60*24)) // Sat Oct 31 2015 03:59:00 GMT-0700 (PDT) new Date((new Date("<a href="tel:2015110102">2015-11-01 02</a>:59 pdt").getTime()-1000*60*60*24)) // Sat Oct 31 2015 02:59:00 GMT-0700 (PDT)
Subtracting 24 hours from PST (Pacific Standard Time) gives you the day before, but an hour later. Subtracting 24 hours from PDT (Pacific Daylight Time) gives you the day before at the same time. This timezone name-change is how you know which side of DST you’re on.
The same example without specifying a timezone chooses your local timezone (which for me is PST):
new Date((new Date("2015-11-01 02:59").getTime()-1000*60*60*24)) // Sat Oct 31 2015 03:59:00 GMT-0700 (PDT)
Now let’s see what happens in March, when daylight savings time goes back into effect:
new Date((new Date("2015-03-08 02:30 pdt").getTime()-1000*60*60*24)) // Sat Mar 07 2015 01:30:00 GMT-0800 (PST) new Date((new Date("2015-03-08 02:30 pst").getTime()-1000*60*60*24)) // Sat Mar 07 2015 02:30:00 GMT-0800 (PST)
At least, this is what happened when I ran the code in San Francisco. When I tried in Denver, a few days later, it looked like this:
new Date((new Date("2015-11-01 02:59 pst").getTime()-1000*60*60*24)) // Sat Oct 31 2015 04:59:00 GMT-0600 (MDT) new Date((new Date("2015-11-01 02:59 pdt").getTime()-1000*60*60*24)) // Sat Oct 31 2015 03:59:00 GMT-0600 (MDT) new Date((new Date("2015-11-01 01:59 pdt").getTime()-1000*60*60*24)) // Sat Oct 31 2015 02:59:00 GMT-0600 (MDT) new Date((new Date("2015-11-01 01:59 pst").getTime()-1000*60*60*24)) // Sat Oct 31 2015 03:59:00 GMT-0600 (MDT)
Notice the funny part? At 2:59, we’re hit by San Francisco’s DST change. At 1:59, we’re hit with Denver’s DST change. That’s because Denver is on Mountain Time, which is an hour ahead of Pacific Time. So Denver goes through the DST change an hour before San Francisco does. Mind = blown.
You might not care about any of this, but if your job is to capture all of X from yesterday, then you’re in for a ride when your boss or client says, “Errrr, there seems to be a whole hour of events missing. That’s 10,000 datapoints. Where did they go?”
Then there are leap seconds.
In a way, leap seconds are less of a problem because you can only get it wrong by a second; but, when you’re calculating with Unix epoch times (which is what
getTime() does, by the way), you don’t have the luxury of timezones. Not that timezones would help for leap seconds.
You’d think a system that counts seconds since January 1st, 1970, wouldn’t have this problem. Unfortunately, you’d be wrong.
Observe that when a positive leap second occurs (i.e., when a leap second is inserted), the Unix time numbers repeat themselves. The Unix time number 915148800.50 is ambiguous. It can refer either to the instant in the middle of the leap second, or to the instant one second later, half a second after midnight UTC.
&embdash; Wikipedia (https://en.wikipedia.org/wiki/Unix_time)
new Date(new Date("1999-01-01T00:00:00.00").getTime()-1000*60*60*24) // Wed Dec 30 1998 16:00:00 GMT-0800 (PST)
Ok. That’s bad. We’ve lost an entire day. I’m pretty sure that’s going to be a problem. If your boss or client was unhappy about the 10,000 datapoints you missed when you got it wrong by an hour, how will they feel about losing 240,000 datapoints?
Oh, and by the way, stop using Unix timestamps as unique identifiers because they’re not unique.
All that said, there were two or three people that put garlic around their necks, tossed salt over their shoulders, and ran as fast as their legs would carry them.
— Aron (@MrAronD) November 3, 2015
— galar (@galar) November 4, 2015
You should read the falsehoods article. Dealing with time is a minefield.
Oh, one more thing. Relativistic effects come into play for rocket guidance systems, things running on space stations, and anything moving quickly. That’s when a second is no longer a second.
Let’s hope neither the military nor any astronauts ever use your real-time smartphone app or website.
P.S.: There’s internet on the International Space Station. 😉
Learned something new? Want to improve your skills?
Join over 10,000 engineers just like you already improving their skills!
Here's how it works 👇
PS: You should also follow me on twitter 👉 here.
It's where I go to shoot the shit about programming.