Swizec Teller - a geek with a hatswizec.com

Senior Mindset Book

Get promoted, earn a bigger salary, work for top companies

Senior Engineer Mindset cover
Learn more

    Functional isn't always better

    A BDSM-style collar that buckles in the back. ...

    For a long time now I've been completely in love with functional programming to the point that I write functional-style code even in run of the mill normal languages.

    There are many reasons I like functional code, the paper Why functional programming matters, by John Hughes sums up my opinion perfectly.

    A few days ago I came upon a problem that killed my idea of functional code being superior and awesome beyond belief. This might have happened because I'm not a very good functional programmer yet, or the tool I was using (javascript) just doesn't support the right things ... but I doubt I would have written it any better in clojure.

    The problem is one of turning a list of values, say, [A, B, C, D] into a list of pairs with itself, like so [[A,B], [A,C], [A,D], [B, C], [B,D], [C,D]].

    Should be simple enough right? You just make another list shifted by one to the left, make a zip, then repeat until the second list is empty. This solution turns out to be horrible, looks ugly and I'm not even going to show it. So here's my second functional solution ... it's a lot cleaner.

    function pairs_functional2(data) {
        return _.reduce(_.map(_.range(1, _.size(data)),
                             function (i) {
                                 return _.map(_.rest(data, i),
                                              function (item) {
                                                  return [data[i-1], item];
                                              });
                             }),
                       function (memo, pairs) {
                           _.map(pairs, function (pair) {
                               memo.push(pair);
                           });
                           return memo;
                       }, []);
    

    A little syntactic sugar wouldn't hurt ... writing a lambda in javascript isn't the cleanest of beasts. That final reduce down there also isn't the best of things from a functional standpoint. I don't like that push, but honestly I didn't know how to do that better.

    Here's an iterative solution for comparison:

    function pairs_iterative(data) {
      var out = [];
      for (var i = 0; i < _.size(data); i++) {
        for (var j = i + 1; j < _.size(data); j++) {
          out.push([data[i], data[j]]);
        }
      }
      return out;
    }
    

    I haven't looked at performance, but both implementations are functionally the same ... I'm feeling a bit at a loss here. Am I doing something stupid in the first implementation? Or is this just the kind of problem that fits iterative programming better than functional?

    I'm tempted to do an implementation in clojure just to see if this thing looks so ugly in javascript on account of the syntax ...

    PS: the original implementation uses underscore.js so it works in all browsers just as the iterative would. Also I don't think javascript natively has enough such functions ... it would be even uglier.

    Published on October 7th, 2011 in Clojure, Functional programming, JavaScript, Languages, Lisp, Programming, Uncategorized

    Did you enjoy this article?

    Continue reading about Functional isn't always better

    Semantically similar articles hand-picked by GPT-4

    Senior Mindset Book

    Get promoted, earn a bigger salary, work for top companies

    Learn more

    Have a burning question that you think I can answer? Hit me up on twitter and I'll do my best.

    Who am I and who do I help? I'm Swizec Teller and I turn coders into engineers with "Raw and honest from the heart!" writing. No bullshit. Real insights into the career and skills of a modern software engineer.

    Want to become a true senior engineer? Take ownership, have autonomy, and be a force multiplier on your team. The Senior Engineer Mindset ebook can help 👉 swizec.com/senior-mindset. These are the shifts in mindset that unlocked my career.

    Curious about Serverless and the modern backend? Check out Serverless Handbook, for frontend engineers 👉 ServerlessHandbook.dev

    Want to Stop copy pasting D3 examples and create data visualizations of your own? Learn how to build scalable dataviz React components your whole team can understand with React for Data Visualization

    Want to get my best emails on JavaScript, React, Serverless, Fullstack Web, or Indie Hacking? Check out swizec.com/collections

    Did someone amazing share this letter with you? Wonderful! You can sign up for my weekly letters for software engineers on their path to greatness, here: swizec.com/blog

    Want to brush up on your modern JavaScript syntax? Check out my interactive cheatsheet: es6cheatsheet.com

    By the way, just in case no one has told you it yet today: I love and appreciate you for who you are ❤️

    Created by Swizec with ❤️